fix(rng): Ensure reproduciblity through construction and reset #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heyo,
This address issue #83 which seemed a bit more deep-rooted than I thought, i.e. not just seeding the configspace.
The main change is to never share the rng object itself but rather pass around seeds generated from it, making things like
reset()
much easier to deal with. Also prevents having to save and store random state object internals.Tested with the following script, which should probably be made into a full-fledged test for reproducibility.