Send Tango unambiguous filenames for user handins

[cg2v]

Summary

Summary generated by Reviewpad on 18 Jul 23 17:15 UTC

This pull request includes three patches:

1. The first patch exports a new method handin_file_long_filename in the Submission model, which generates a long filename for the handin file by including the student's email address.

2. The second patch allows the autogradeInputFiles method in the assessment_autograde_core helper to provide a remoteFile attribute for autograding file uploads to the Tango server. If remoteFile is not provided, the value of localFile will be used instead.

3. The third patch updates the autogradeInputFiles method in the assessment_autograde_core helper to use the full filename (including the student's email address) for handin file uploads to the Tango server.

Please review these patches for implementation correctness and possible improvements.

Description

Tango handin filenames need to be unique per user/version (and also course/assessment) so that grading always applies to the student's work and not someone elses. This patch restores the upload filename to <email>_<version>_<handin>.<ext> from <version>_<handin>.<ext>

Motivation and Context

Since #1831 , autolab has been sending tango filenames of the form <version>_<handin>.<ext>. This means that if multiple students submit near-simultaneously, and they are at the the same version number, it is likely that the grade both receive will be based on only one of their handins.

How Has This Been Tested?

Deployed to autolab-dev.andrew.cmu.edu
Submitted new handin for https://autolab-dev.andrew.cmu.edu/courses/TestCourse-s23/assessments/hello
Verified that the files uploaded to tango had the email address in them for both new handins and regrades.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
• My change requires a change to the documentation, which is located at Autolab Docs
• I have updated the documentation accordingly, included in this PR

Other issues / help required

If someone is working on an alternative approach, feel free to reject this PR

[damianhxy]

Thanks for the PR! (I presume you meant to reference #1831 instead)

[cg2v]

Now tested on autolab-dev. Seems to work

root@autolab-tango-d01 /]# ls /home/autolab/courselabs/KEY-TestCourse-s23-hello/
1_hello.c  4_hello.c  autograde-Makefile             [email protected]_2_hello.c
2_hello.c  5_hello.c  autograde.tar                  [email protected]_3_hello.c
3_hello.c  6_hello.c  [email protected]_1_hello.c  output

[cg2v]

Reference and testing status updated in summary

[20wildmanj]

Reproduced submission error locally through autolab, and verified that fix works correctly:

Reproduction Strategy (on master):

• Use this autograded assessment (takes in a python file, returns score based on number function you define spits out):
  tangotestlab.zip, handin:
  returnNum.py.txt

• Submit as different users different values, get a list of submissions like so:
  

• Go to "Manage Submissions" and click "Regrade All"

• See that when regrade finishes, all students have same score (seems to always be the last user's submission)
  

Checked out branch, restarted autolab, and regraded, saw that grades matched expected values for students:

Fix LGTM, thanks for the work you did to solve our issue!