Switch postgres to use a set and return an error if a duplicate caveat name is given #2199
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t name is given This condition should never happen in real code, but the constraint failure error was causing the PG driver to retry over and over, making the test incredibly slow. Instead, we now check on the client side and return a non-retryable error.
tstirrat15
approved these changes
Jan 10, 2025
|
@tstirrat15 we need to collect the names anyway, so converting from a set -> slice should be fairly low impact |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This condition should never happen in real code, but the constraint failure error was causing the PG driver to retry over and over, making the test incredibly slow. Instead, we now check on the client side and return a non-retryable error.