Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/react19 #823

Closed
wants to merge 7 commits into from
Closed

feature/react19 #823

wants to merge 7 commits into from

Conversation

tusharpandey13
Copy link
Contributor

@tusharpandey13 tusharpandey13 commented Jan 15, 2025

This change enables React 19 support for auth0-react
This change builds upon PR #819 by @leefreemanxyz

Changes

  • Version bumps of related packages in package.json, package-lock.json update.
  • Updated tests to use the new version of packages.
  • Added handling for an edge case where error was not thrown if popup was closed in loginWithPopup.
  • Updated sample code to use React 19.
  • Linting changes.

Commits

  • feat(react 19): update react to 19, testing libraries deps to latest and fix broken tests
  • chore: update @types/react and @types/react-dom to version 19.0.0
  • refactor: remove explicit return types for functional components in tests and providers
  • add explicit type annotations for React.JSX.Element
  • handle popup closed error not thrown
  • update example code
  • update tests
  • package json changes

Testing

PASSING

=============================== Coverage summary ===============================
Statements   : 100% ( 166/166 )
Branches     : 100% ( 72/72 )
Functions    : 100% ( 41/41 )
Lines        : 100% ( 158/158 )
================================================================================

Test Suites: 8 passed, 8 total
Tests:       81 passed, 81 total
Snapshots:   0 total
Time:        4.995 s
Ran all test suites.
  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

nandan-bhat
nandan-bhat previously approved these changes Jan 15, 2025
nandan-bhat
nandan-bhat previously approved these changes Jan 16, 2025
@tusharpandey13 tusharpandey13 deleted the feature/react19 branch January 21, 2025 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants