Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make OAuthError extend GenericError #638

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Make OAuthError extend GenericError #638

merged 4 commits into from
Oct 31, 2023

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Oct 31, 2023 •
edited
Loading

Description

For consistency, this PR makes OAuthError extend GenericError, which still extends Error.

References

#636

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@frederikprijck frederikprijck requested a review from a team as a code owner October 31, 2023 08:43
@frederikprijck frederikprijck temporarily deployed to internal October 31, 2023 08:43 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal October 31, 2023 08:43 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal October 31, 2023 08:43 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal October 31, 2023 08:43 — with GitHub Actions Inactive
frederikprijck
frederikprijck commented Oct 31, 2023
View reviewed changes
src/errors.tsx
super(error_description || error);
export class OAuthError extends GenericError {
constructor(public error: string, public error_description: string = '') {
super(error, error_description || error);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second argument is passed to the Error constructor, so I ensured it's identical as before.

frederikprijck
frederikprijck commented Oct 31, 2023
View reviewed changes
src/errors.tsx Outdated Show resolved Hide resolved
@frederikprijck frederikprijck temporarily deployed to internal October 31, 2023 08:56 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal October 31, 2023 08:56 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal October 31, 2023 08:56 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal October 31, 2023 08:56 — with GitHub Actions Inactive
@frederikprijck @adamjmcgrath
Update src/errors.tsx
ce016d4 
Co-authored-by: Adam Mcgrath <[email protected]>
Signed-off-by: Frederik Prijck <[email protected]>
@frederikprijck frederikprijck temporarily deployed to internal October 31, 2023 09:28 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal October 31, 2023 09:28 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal October 31, 2023 09:28 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal October 31, 2023 09:28 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal October 31, 2023 09:41 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal October 31, 2023 09:41 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal October 31, 2023 09:41 — with GitHub Actions Inactive
@frederikprijck frederikprijck temporarily deployed to internal October 31, 2023 09:41 — with GitHub Actions Inactive
@frederikprijck frederikprijck merged commit 9079a32 into main Oct 31, 2023
12 checks passed
@frederikprijck frederikprijck deleted the chore/oautherror branch October 31, 2023 09:49
@frederikprijck frederikprijck mentioned this pull request Oct 31, 2023
Merged
@elstgav elstgav mentioned this pull request Nov 1, 2023
Closed
6 tasks
frederikprijck added a commit that referenced this pull request Nov 2, 2023
@frederikprijck
Revert "Make OAuthError extend GenericError (#638)"
ce14fdf 
This reverts commit 9079a32.
@frederikprijck frederikprijck mentioned this pull request Nov 2, 2023
Merged
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elstgav elstgav elstgav left review comments

@adamjmcgrath adamjmcgrath adamjmcgrath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frederikprijck @elstgav @adamjmcgrath