Add "All" getters to segment #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add whitelist to phpunit config
Add methods to Segment: - getAll() - getFlashAll() - getFlashNextAll()
| @@ -4,4 +4,9 @@ | |||
| <directory>./tests</directory> | |||
| </testsuite> | |||
| </testsuites> | |||
| <filter> | |||
There was a problem hiding this comment.
Sorry I missed to see you have already added this. Was looking at travis and it notifies the problem and ie why ended up adding in #50 .
|
@harikt , Good point! It probably doesnt make sense to add to Segment without changing the Interface, right? |
|
Yes probably you could check 3.x branch may be that is good. Ping @pmjones for more information where it should go. |
|
Closing in favor of #52 since the change in the interface is a breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add methods to Segment: