-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add comment in conditional_mnist.ipynb
for training FM
#97
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
=======================================
Coverage 35.92% 35.92%
=======================================
Files 67 67
Lines 7399 7399
=======================================
Hits 2658 2658
Misses 4741 4741 ☔ View full report in Codecov by Sentry. |
Hello, Thank you for your contribution. We have discussed with Alex and we think it is not the purpose of notebooks to have this kind of flags and several variants. The reason is that the notebooks have a pedagogical purpose. Instead of adding a flag, it would be better in our opinion to add the following sentence under line 10 of the current notebook:
You are welcome to update your PR if you want to keep contributing. Once again, thank you for your contribution. |
USE_ICFM
in conditional_mnist.ipynb
to allow training both FM and ICFMconditional_mnist.ipynb
for training FM
Thank you for the comment, I updated the PR. |
61c02ce
to
ef9fb89
Compare
Hi, I think it is better if we explain what we want to do to users. Therefore, I would keep
Thanks |
Sure! |
Thanks, it looks good to me. I am now merging. |
This PR includes a "flag"
USE_ICFM
inconditional_mnist.ipynb
(similar to what is done here intrain_cifar10.py
) to allow training both FM and ICFM.pytest
command?pre-commit run -a
command?