Exposed the trusted field for developer keys in the admin panel #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpetrowi
pushed a commit
that referenced
this pull request
Apr 26, 2021
closes MAT-47
flag=expand_cc_languages
Update the list of closedCaptionLanguages to all those supported
in Canvas. How did I come up with the list?
1. load a page with an RCE
2. set a breakpoint at the bottom of closedCaptionLanguages and refresh
3. copy the result of `Object.keys(closedCaptionLanguages)`. This are the
old locales
4. open a rails console
5. run
cnvs_l = []
I18n.available_locales.each {|s| cnvs_s << s.to_s}
old_l = <paste result of #3 above>
the_missing_locales = cnvs_l - old_l
I added the missing locales to closedCaptionLanguages.
Then I removed zh_cn and zh_tw because those are not Simplified and
Traditional Chinese, but PRC and Taiwan Chinese.
I changed Hebrew from iw to he.
I left languages in the closedCaptionLanguages.js file that are
not in Canvas.
I did not use the *-x-k12 locales
test plan:
- put the user in English (Canada) and turn on the auto show
closed caption feature
- on a video in the RCE, open the Video Options tray
- click on the + subtitle button
> expect the full list of locales (like English (UK) and Armenian)
- add subtitles for English and English (UK)
a valid .srt file looks like:
1
00:00:00,000 --> 00:00:02,000
My first video
it will be helpful to edit the string a little for the different
languages so you can recognize what language file is being shown.
> expect generic english captions
- Delete the English subtitle and add any other language but English
> expect the subtitles to be in English (UK)
- add subtitles for English (Canada)
> expect subtitles to be in English (Canada)
Change-Id: I8f18d666482a67063a3b8101b7778e32cd440b45
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/262794
Tested-by: Service Cloud Jenkins <[email protected]>
Reviewed-by: Nate Armstrong <[email protected]>
QA-Review: Nate Armstrong <[email protected]>
Product-Review: Ed Schiebel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to set a developer key as trusted, which lets you skip the OAUTH approval view. This is helpful for creating a key for use with login on the mobile apps.