Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Changed spell-checking to be plugin-based. #120

Merged
merged 6 commits into from
Aug 19, 2016

Commits on May 2, 2016

  1. Changed spell-checking to be plugin-based.

    * Changed the package to allow for external packages to provide additional checking. (Closes atom#74)
      - Disabled the task-based handling because of passing plugins.
      - Two default plugins are included: system-based dictionaries and "known words".
      - Suggestions and "add to dictionary" are also provided via interfaces. (Closes atom#10)
      - Modified various calls so they are aware of the where the buffer is located.
    * Modified system to allow for multiple plugins/checkers to identify correctness.
      - Incorrect words must be incorrect for all checkers.
      - Any checker that treats a word as valid is considered valid for the buffer.
    * Extracted system-based dictionary support into separate checker.
      - System dictionaries can now check across multiple system locales.
      - Locale selection can be changed via package settings. (Closes atom#21)
      - Multiple locales can be selected. (Closes atom#11)
      - External search paths can be used for Linux and OS X.
      - Default language is based on the process environment, with a fallback to the browser, before finally using `en-US` as a fallback.
    * Extracted hard-coded approved list into a separate checker.
      - User can add additional "known words" via settings.
      - Added an option to add more known words via the suggestion dialog.
    * Updated ignore files and added EditorConfig settings for development.
    * Various coffee-centric formatting.
    dmoonfire committed May 2, 2016
    Configuration menu
    Copy the full SHA
    8b7ab9c View commit details
    Browse the repository at this point in the history
  2. Updated plugin-based implementation from provided feedback.

    - Switched to a task-based system.
        - Reworked the plugins so they return full paths to a `require`able instance.
        - Modified the activation/deactivation to create a single background task for all checking.
        - Initial request for corrections will have a delay while an in-process manager is created.
        - Added flow control via `send` and `emit` to communicate configuration changes with the task process.
    - Changed to a word-based searching implementation.
        - Added a simplified tokenizer that includes some accented characters.
        - An internal cache is used for a single round of check to reduce overhead.
        - Removed the use of integer ranges and simplified processing logic.
    - Removed a number of `console.log` calls used for debugging.
    - Updated documentation.
        - Split out plugin creation into a separate document with a reference in the `README.md`.
    dmoonfire committed May 2, 2016
    Configuration menu
    Copy the full SHA
    dff766e View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2016

  1. Converting checking to use multi-integer-range with a task-based ch…

    …ecking.
    
    * Updated unit tests to verify functionality of multiple plugin responses.
    * Taught system checking how to identify correct as well as incorrect.
    * Updated documentation to reflect plugin logic.
    dmoonfire committed Jul 7, 2016
    Configuration menu
    Copy the full SHA
    f47f54c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0259d21 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a509817 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2016

  1. Updated code with requested changes:

    * Removed ".coffee" from require statements.
    * Moved empty array initialization closer to where it was populated.
    dmoonfire committed Aug 13, 2016
    Configuration menu
    Copy the full SHA
    c228c87 View commit details
    Browse the repository at this point in the history