Failed to activate the spell-check package #67
Comments
|
Same here on Windows 7 Machine Newest Atom 0.221.0 Installed Packages Same error on atom wrap-guide package |
|
Same here on a mac. Possibly related issue: atom/atom#6235 |
|
@sinejoe @ElaHo @furins Sorry for the delay in getting back to you on this. Are you still seeing this issue in Atom 1.0.11? If so, do you see the problem when you start Atom in safe mode? Also, can you please provide at least one file for which this error happens so that we can try and reproduce? Or does this happen when you attempt to open any file in any project? |
|
Using Atom 1.3.2 on Windows 7. I got spell-checking working out of the box on one computer, but when I installed Atom with the same packages and settings on another computer (still Win7), it just doesn't work, without even leaving a stack trace... Note: the placeholder text in the settings shows: |
|
Update: I removed Atom from the problematic computer. Cleared all three folders (had problems with packages with too deep dependency tree, exceeding the Windows' max length path; solved by moving up node_modules for these packages). I made a fresh install of Atom 1.3.2. I opened a .md file without changing anything to the settings (so, no 3rd party package, default settings, etc.). Still no spell checking... :-( The first computer uses Windows 7 Professional; the second one, with the problem, uses Windows 10 (upgraded from 7). |
|
I located the sources in the DevTools. It was not obvious, because all files start with Side note: there are 6 Atom processes started. When I see the command line of launch, half of them has no quotes around the path to Atom. It is OK on my system as there are no spaces in the path, but on some systems, it might be problematic. |
|
Am seeing this issue again in 1.26 beta0
Atom: 1.26.0-beta0 x64 Stack TraceFailed to activate the spell-check package CommandsNon-Core Packages |
|
@rcrooks: Thanks for letting us know that you're running into this issue. I'm attempting to reproduce it, but I haven't been able to do so. Does it happen for you every time you open Atom? |
|
@jasonrudolph no, that's the odd thing. It appears sometimes, but not every time. and only on the beta version (1.26.1, not the release version |
@maxbrunsfeld @as-cii: Do you see anything in that stack trace ☝️ that might offer a hint as to the root cause of this issue? I'd love to resolve this problem before Atom 1.26 graduates from beta to stable. |
|
The error looks like it's related to the I'm not familiar with It seems that it uses an old node module called @dmoonfire do you have any insight into what might be going on here? |
|
@maxbrunsfeld: Thanks for that insight. 🙇⚡ tl;dr I think we might be able to resolve this issue by omitting the webworker-threads module from the build. I've described my findings so far below. Does this idea seem reasonable? If so, is there a preferred way to omit the webworker-threads module from the build? FindingsHere's the dependency chain I'm seeing: spell-check ➡️ spelling-manager ➡️ natural ➡️ webworker-threads ➡️ bindings I think the issue we're seeing has to due with natural's dependency on webworker-threads. I came across a few other people mentioning issues attempting to use the webworker-threads module with Electron:
The natural module declares webworker-threads as an optionalDependency (NaturalNode/natural#354). If webworker-threads is installed, the natural module attempts to use it [code]. NaturalNode/natural#368 explains that deleting the the webworker-threads module only works on Node, and not on Electron. NaturalNode/natural#368 goes on to say that you can work around the issue by deleting the
Since that seems to resolve the issue, is there a way that we can teach Atom (or the spell-check package) to not install the webworker-threads module? One (super hacky) option might be to add a post-install hook on the spell-check package to delete the webworker-threads module. For example, imagine something like this, but tweaked to run in a cross-platform manner: --- a/package.json
+++ b/package.json
@@ -84,5 +84,8 @@
"^1.0.0": "consumeSpellCheckers"
}
}
+ },
+ "scripts": {
+ "postinstall": "rm -rf node_modules/webworker-threads"
}
} |
|
👍 Yeah that seems worth a try. |
|
That is reasonable. Likewise, I can also work to get rid of |
|
@jasonrudolph I am also able to reproduce it sometimes but not every time. I'll grab a stack trace next time I encounter it. is there any other debug output that would be helpful that I could try to capture? |
|
@maxbrunsfeld @dmoonfire: Thank you! I'll give this approach a shot in #244. @annthurium: I can't think of any additional debug output to capture. If I think of any, I'll definitely let you know. 🙇 |
|
The problem seen in #67 (comment) should be resolved by #246. That fix is included in Atom 1.26-beta2 (released today) and will be part of Atom 1.26 stable when it is released. I'm going to close this issue. If you're using Atom 1.26-beta2 (or newer) and you continue to see this problem, please open a new issue to let us know. |
[Enter steps to reproduce below:]
Atom Version: 0.211.0
System: Mac OS X 10.10.3
Thrown From: spell-check package, v0.59.0
Stack Trace
Failed to activate the spell-check package
Commands
Config
{ "core": { "themes": [ "atom-dark-ui", "monokai-dark" ], "ignoredNames": [ ".git", ".svn", ".DS_Store", ".hg", "*.pyc", "node_modules" ], "projectHome": "/var/www", "disabledPackages": [ "wrap-guide" ] } }Installed Packages
The text was updated successfully, but these errors were encountered: