Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Add .svg support #165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add .svg support #165

wants to merge 1 commit into from

Conversation

jdanbrown
Copy link

@jdanbrown jdanbrown commented Nov 27, 2017 •
edited
Loading

  • Looks like it already works, only needs to be whitelisted

@jdanbrown
Add .svg support
21b9990 
- Looks like it already works, only needs to be whitelisted
jdanbrown added a commit to jdanbrown/image-view that referenced this pull request Nov 27, 2017
@jdanbrown
zoomToFit should allow image to scale up to full parent size
259c46a 
If the user overrides `object-fit` from `scale-down` to `contain` like:
```css
.image-view .zoom-to-fit.image-container img {
  object-fit: contain;
}
```

then before this change an svg image (atom#165) wouldn't scale up beyond its
default size. After this change an svg image does scale up to fill the
whole window.
jdanbrown added a commit to jdanbrown/image-view that referenced this pull request Nov 27, 2017
@jdanbrown
zoomToFit should allow image to scale up to full parent size
88070ec 
If the user overrides `object-fit` from `scale-down` to `contain` like:
```css
.image-view .zoom-to-fit.image-container img {
  object-fit: contain;
}
```

then before this change an svg image (atom#165) wouldn't scale up beyond its
default size. After this change an svg image does scale up to fill the
whole window.
@TimvdLippe
Copy link
Contributor

Since .svg is text-based, would this prevent anyone from modifying the text of the svg with Atom?

@winstliu
Copy link
Contributor

@jdanbrown how do you propose addressing @TimvdLippe's concern?

@jdanbrown
Copy link
Author

How about make it a toggleable option in the package settings? I expect most people will prefer image over text most of the time or vice versa, and adding the option is strictly more functionality than what currently exists.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
more-information-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdanbrown @TimvdLippe @winstliu