Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chat: add associations of user profiles and private chat fix #92

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

Heisjabo
Copy link
Collaborator

What does this PR do?

  • This PR fixes chat endpoints to include user profile associations and private chat socket for message emission

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 53.48837% with 20 lines in your changes missing coverage. Please review.

Project coverage is 74.15%. Comparing base (bfa3e5f) to head (f03aa8a).
Report is 2 commits behind head on dev.

Files Patch % Lines
src/controllers/userControllers.ts 10.00% 9 Missing ⚠️
src/services/user.service.ts 14.28% 5 Missing and 1 partial ⚠️
src/services/privateChat.service.ts 33.33% 4 Missing ⚠️
src/config/socketCofing.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #92      +/-   ##
==========================================
- Coverage   74.29%   74.15%   -0.15%     
==========================================
  Files         126      125       -1     
  Lines        2280     2267      -13     
  Branches      311      293      -18     
==========================================
- Hits         1694     1681      -13     
- Misses        565      568       +3     
+ Partials       21       18       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Add user profile associations on chats
- fix private chat socket
@teerenzo teerenzo merged commit e9d0346 into dev Jul 18, 2024
2 checks passed
niyobertin pushed a commit that referenced this pull request Jul 20, 2024
Fix chat: add associations of user profiles and private chat fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants