Ft google auth #187419170 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MugemaneBertin2001
requested review from
dniwemugisha,
teerenzo,
Heisjabo and
soleil00
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 10538571 | Triggered | Generic Password | 9ff45bd | test/user.test.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #34 +/- ##
==========================================
- Coverage 78.11% 75.29% -2.83%
==========================================
Files 24 25 +1
Lines 297 340 +43
Branches 38 42 +4
==========================================
+ Hits 232 256 +24
- Misses 65 84 +19 ☔ View full report in Codecov by Sentry. |
- Implement the feature to allow users update their password
- Added validation check for old password, new password and confirm
password
- hash the new password before updating
- documented the feature using swagger
[Delivers #187419174]
Feat(authentication): implementation of google authentication
- Add signin and sign up with google account
- return access token
- added test
delivers #187419170
--amend
Feat(authentication): implementation of google authentication
- Add signin and sign up with google account
- return access token
- added test
delivers #187419170
Fixed missing login body in swagger doc
fix: fixed 2fa implemetation by replacing verification link with otp code
fix(profile-edit): fix password not being updated in the database
- fixed the issue of password not being updated in the database
[Fixes #187419174]
MugemaneBertin2001
force-pushed
the
ft-google-auth-#187419170
branch
from
c54ecd5 to
3ac1046
Compare
soleil00
approved these changes
Apr 30, 2024
teerenzo
requested changes
Apr 30, 2024
__test__/user.test.ts
Outdated
| @@ -94,7 +100,7 @@ describe("Testing user Routes", () => { | |||
| spyonOne.mockRestore(); | |||
| }, 20000); | |||
|
|
|||
| test("Should send otp verification code", async () => { | |||
| test.skip("Should send otp verification code", async () => { | |||
There was a problem hiding this comment.
I have worked on your request
Heisjabo
approved these changes
Apr 30, 2024
MugemaneBertin2001
force-pushed
the
ft-google-auth-#187419170
branch
from
5d7feef to
9ff45bd
Compare
MugemaneBertin2001
force-pushed
the
ft-google-auth-#187419170
branch
from
242a3fd to
6103a67
Compare
MugemaneBertin2001
force-pushed
the
ft-google-auth-#187419170
branch
from
545fcbb to
de3b324
Compare
teerenzo
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what does this PR do?
Description of task to be completed:
How to test it
ft-google-auth-#187419170What are the relevant pivotal tracker stories?
[Feat: #187419170 ]