Ft google auth #187419170 #27

MugemaneBertin2001 · 2024-04-23T23:14:00Z

what does this PR do?

Help user to sign up and login with existing google account

Description of Task to be completed:

As a user I should be able to athenticate (register/login) via Google

how to test it

go to ft-google-auth-#187419170 branch
clone this repo
create and fill .env with local configuration
run the app
go to browser : localhost:3000/login
click on URL for login with google
follow on screen instruction

teerenzo · 2024-04-24T16:45:21Z

.env.example

+CLOUDINARY_CLOUD_NAME= "" use yours
+CLOUDINARY_API_KEY= "" use yours
+CLOUDINARY_API_SECRET= "" use yours


we don't need this

teerenzo · 2024-04-24T16:45:43Z

.vscode/settings.json

+{
+    "sqltools.connections": [
+        {
+            "previewLimit": 50,
+            "server": "localhost",
+            "port": 5432,
+            "driver": "PostgreSQL",
+            "name": "new",
+            "group": "new",
+            "database": "ecommerce_db",
+            "username": "postgres"
+        }
+    ]
+}


please pay attention

added .vscode in .gitignore and removed it

teerenzo · 2024-04-24T16:46:19Z

__test__/home.test.ts

+    expect(response.status).toBe(200);
+  }, 20000);
+  test("server should return status code of 200 and link to log in with google --> given'/login'", async () => {
+    const response = await request(app).get("/login");
+    expect(response.text).toBe("<a href='/auth/google'>click to here to Login</a>")
+


you should test what you have done not what you use to test it

added tests for my endpoints

teerenzo · 2024-04-24T16:49:15Z

src/utils/server.ts

 app.use(cors());

 app.use("/", homeRoute);
 app.use("/api/v1", appROutes);
 app.use("/docs", docRouter);
+app.use('/', googleRoutes)


remove this here,

refined as requested

teerenzo · 2024-04-24T16:50:15Z

PR name and description is wrong please check on naming convertion again

hound · 2024-04-26T11:46:16Z

eslint.config.js

+	{
+		files: ["*.ts", "*.js"],
+		...tseslint.configs.disableTypeChecked,
+	},


Unexpected '}'.

hound · 2024-04-26T11:46:16Z

eslint.config.js

+	},
+	{
+		files: ["*.ts", "*.js"],
+		...tseslint.configs.disableTypeChecked,


Expected ')' and instead saw 'tseslint'.
Expected '}' to match '{' from line 18 and instead saw '...'.
Expected an assignment or function call and instead saw an expression.
Missing semicolon.
Unrecoverable syntax error. (39% scanned).

hound · 2024-04-26T11:46:16Z

eslint.config.js

+		ignores: ["**/__test__", "**/*.json"],
+	},
+	eslint.configs.recommended,
+	...tseslint.configs.recommended,


'spread/rest operator' is only available in ES6 (use 'esversion: 6').

hound · 2024-04-26T11:46:16Z

eslint.config.js

@@ -0,0 +1,51 @@
+const eslint = require("@eslint/js");
+const tseslint = require("typescript-eslint");


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2024-04-26T11:46:16Z

eslint.config.js

@@ -0,0 +1,51 @@
+const eslint = require("@eslint/js");


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2024-04-26T11:46:16Z

eslint.config.js

+	{
+		files: ["*.ts", "*.js"],
+		...tseslint.configs.disableTypeChecked,
+	},


Unexpected '}'.

hound · 2024-04-26T11:46:16Z

eslint.config.js

+	},
+	{
+		files: ["*.ts", "*.js"],
+		...tseslint.configs.disableTypeChecked,


Expected ')' and instead saw 'tseslint'.
Expected '}' to match '{' from line 18 and instead saw '...'.
Expected an assignment or function call and instead saw an expression.
Missing semicolon.
Unrecoverable syntax error. (39% scanned).

hound · 2024-04-26T11:46:16Z

eslint.config.js

+		ignores: ["**/__test__", "**/*.json"],
+	},
+	eslint.configs.recommended,
+	...tseslint.configs.recommended,


'spread/rest operator' is only available in ES6 (use 'esversion: 6').

hound · 2024-04-26T11:46:16Z

eslint.config.js

@@ -0,0 +1,51 @@
+const eslint = require("@eslint/js");
+const tseslint = require("typescript-eslint");


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2024-04-26T11:46:16Z

eslint.config.js

@@ -0,0 +1,51 @@
+const eslint = require("@eslint/js");


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2024-04-26T11:46:16Z

eslint.config.js

+	{
+		files: ["*.ts", "*.js"],
+		...tseslint.configs.disableTypeChecked,
+	},


Unexpected '}'.

hound · 2024-04-26T11:46:16Z

eslint.config.js

+	},
+	{
+		files: ["*.ts", "*.js"],
+		...tseslint.configs.disableTypeChecked,


Expected ')' and instead saw 'tseslint'.
Expected '}' to match '{' from line 18 and instead saw '...'.
Expected an assignment or function call and instead saw an expression.
Missing semicolon.
Unrecoverable syntax error. (39% scanned).

hound · 2024-04-26T11:46:16Z

eslint.config.js

+		ignores: ["**/__test__", "**/*.json"],
+	},
+	eslint.configs.recommended,
+	...tseslint.configs.recommended,


'spread/rest operator' is only available in ES6 (use 'esversion: 6').

hound · 2024-04-26T11:46:16Z

eslint.config.js

@@ -0,0 +1,51 @@
+const eslint = require("@eslint/js");
+const tseslint = require("typescript-eslint");


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2024-04-26T11:46:16Z

eslint.config.js

@@ -0,0 +1,51 @@
+const eslint = require("@eslint/js");


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2024-04-26T11:46:16Z

eslint.config.js

+	{
+		files: ["*.ts", "*.js"],
+		...tseslint.configs.disableTypeChecked,
+	},


Unexpected '}'.

hound · 2024-04-26T11:46:16Z

eslint.config.js

+	},
+	{
+		files: ["*.ts", "*.js"],
+		...tseslint.configs.disableTypeChecked,


Expected ')' and instead saw 'tseslint'.
Expected '}' to match '{' from line 18 and instead saw '...'.
Expected an assignment or function call and instead saw an expression.
Missing semicolon.
Unrecoverable syntax error. (39% scanned).

hound · 2024-04-26T11:46:16Z

eslint.config.js

+		ignores: ["**/__test__", "**/*.json"],
+	},
+	eslint.configs.recommended,
+	...tseslint.configs.recommended,


'spread/rest operator' is only available in ES6 (use 'esversion: 6').

hound · 2024-04-26T11:46:17Z

eslint.config.js

@@ -0,0 +1,51 @@
+const eslint = require("@eslint/js");
+const tseslint = require("typescript-eslint");


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2024-04-26T11:46:17Z

eslint.config.js

@@ -0,0 +1,51 @@
+const eslint = require("@eslint/js");


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2024-04-26T11:46:17Z

eslint.config.js

+	{
+		files: ["*.ts", "*.js"],
+		...tseslint.configs.disableTypeChecked,
+	},


Unexpected '}'.

hound · 2024-04-26T11:46:17Z

eslint.config.js

+	},
+	{
+		files: ["*.ts", "*.js"],
+		...tseslint.configs.disableTypeChecked,


Expected ')' and instead saw 'tseslint'.
Expected '}' to match '{' from line 18 and instead saw '...'.
Expected an assignment or function call and instead saw an expression.
Missing semicolon.
Unrecoverable syntax error. (39% scanned).

hound · 2024-04-26T11:46:17Z

eslint.config.js

+		ignores: ["**/__test__", "**/*.json"],
+	},
+	eslint.configs.recommended,
+	...tseslint.configs.recommended,


'spread/rest operator' is only available in ES6 (use 'esversion: 6').

hound · 2024-04-26T11:46:17Z

eslint.config.js

@@ -0,0 +1,51 @@
+const eslint = require("@eslint/js");
+const tseslint = require("typescript-eslint");


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2024-04-26T11:46:17Z

eslint.config.js

@@ -0,0 +1,51 @@
+const eslint = require("@eslint/js");


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

gitguardian · 2024-04-26T11:46:21Z

⚠️ GitGuardian has uncovered 7 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
10286351	Triggered	Company Email Password	`68e9929`	src/sequelize/seeders/20240412144111-demo-user.js	View secret
10286351	Triggered	Company Email Password	`bd9384b`	src/sequelize/seeders/20240412144111-demo-user.js	View secret
10286352	Triggered	Generic Password	`68e9929`	src/sequelize/seeders/20240412144111-demo-user.js	View secret
10286352	Triggered	Generic Password	`bd9384b`	src/sequelize/seeders/20240412144111-demo-user.js	View secret
10286352	Triggered	Generic Password	`bd9384b`	src/sequelize/seeders/20240412144111-demo-user.js	View secret
10286352	Triggered	Generic Password	`68e9929`	src/sequelize/seeders/20240412144111-demo-user.js	View secret
10538571	Triggered	Generic Password	`12b02a5`	test/user.test.ts	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

teerenzo · 2024-04-26T11:48:50Z

you have many commits bertin squash them and are you sure you have changed 40 files

- Implement the feature to allow users update their password - Added validation check for old password, new password and confirm password - hash the new password before updating - documented the feature using swagger [Delivers #187419174]

- Add signin and sign up with google account - return access token - added test delivers #187419170

MugemaneBertin2001 requested review from dniwemugisha, teerenzo, niyobertin, Heisjabo, yvanddniyo and soleil00 April 23, 2024 23:14

teerenzo requested changes Apr 24, 2024

View reviewed changes

MugemaneBertin2001 added the REBASING label Apr 26, 2024

hound bot reviewed Apr 26, 2024

View reviewed changes

MugemaneBertin2001 added the READY FOR REVIEW label Apr 26, 2024

MugemaneBertin2001 removed the REBASING label Apr 26, 2024

IRUMVAEmmanuel1 and others added 6 commits April 26, 2024 15:57

ESLint Configuration PreCommit format and Test

68e9929

ESLint Configuration format

640b1b5

ESLint Configuration format

bd9384b

ESLint Configuration format

df19038

Feat(authentication): implementation of google authentication

b0fc4f4

- Add signin and sign up with google account - return access token - added test delivers #187419170

MugemaneBertin2001 force-pushed the ft-google-auth-#187419170 branch from 4566a10 to b0fc4f4 Compare April 26, 2024 14:25

MugemaneBertin2001 closed this Apr 29, 2024

MugemaneBertin2001 deleted the ft-google-auth-#187419170 branch April 29, 2024 09:00

		@@ -0,0 +1,51 @@
		const eslint = require("@eslint/js");
		const tseslint = require("typescript-eslint");

Ft google auth #187419170 #27

Ft google auth #187419170 #27

Conversation

MugemaneBertin2001 commented Apr 23, 2024 • edited Loading

what does this PR do?

Description of Task to be completed:

how to test it

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

teerenzo commented Apr 24, 2024

hound bot Apr 26, 2024

Choose a reason for hiding this comment

hound bot Apr 26, 2024

Choose a reason for hiding this comment

hound bot Apr 26, 2024

Choose a reason for hiding this comment

hound bot Apr 26, 2024

Choose a reason for hiding this comment

hound bot Apr 26, 2024

Choose a reason for hiding this comment

hound bot Apr 26, 2024

Choose a reason for hiding this comment

hound bot Apr 26, 2024

Choose a reason for hiding this comment

hound bot Apr 26, 2024

Choose a reason for hiding this comment

hound bot Apr 26, 2024

Choose a reason for hiding this comment

hound bot Apr 26, 2024

Choose a reason for hiding this comment

hound bot Apr 26, 2024

Choose a reason for hiding this comment

hound bot Apr 26, 2024

Choose a reason for hiding this comment

hound bot Apr 26, 2024

Choose a reason for hiding this comment

hound bot Apr 26, 2024

Choose a reason for hiding this comment

hound bot Apr 26, 2024

Choose a reason for hiding this comment

hound bot Apr 26, 2024

Choose a reason for hiding this comment

hound bot Apr 26, 2024

Choose a reason for hiding this comment

hound bot Apr 26, 2024

Choose a reason for hiding this comment

hound bot Apr 26, 2024

Choose a reason for hiding this comment

hound bot Apr 26, 2024

Choose a reason for hiding this comment

hound bot Apr 26, 2024

Choose a reason for hiding this comment

hound bot Apr 26, 2024

Choose a reason for hiding this comment

hound bot Apr 26, 2024

Choose a reason for hiding this comment

hound bot Apr 26, 2024

Choose a reason for hiding this comment

hound bot Apr 26, 2024

Choose a reason for hiding this comment

gitguardian bot commented Apr 26, 2024 • edited Loading

⚠️ GitGuardian has uncovered 7 secrets following the scan of your pull request.

teerenzo commented Apr 26, 2024 • edited Loading

MugemaneBertin2001 commented Apr 23, 2024 •

edited

Loading

gitguardian bot commented Apr 26, 2024 •

edited

Loading

teerenzo commented Apr 26, 2024 •

edited

Loading