Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup unit testing #8

Closed
wants to merge 2 commits into from
Closed

setup unit testing #8

wants to merge 2 commits into from

Conversation

hbapte
Copy link
Contributor

@hbapte hbapte commented May 16, 2024

No description provided.

Copy link
Member

@ProgrammerDATCH ProgrammerDATCH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't refer to new changes in develop branch.
I think those tests are no longer needed considering new structure we have, we only need test for /,

Also there is conflicts in your commit, simply because you didn't pull latest changes from develop branch.

Just pull new changes and remove unnecessary changes then resolve conflicts and re-submit pull request.

Happy Coding.

Copy link
Member

@ProgrammerDATCH ProgrammerDATCH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean now.

@ProgrammerDATCH ProgrammerDATCH self-requested a review May 16, 2024 09:29
Copy link
Member

@ProgrammerDATCH ProgrammerDATCH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests are failing on Circle CI, I looked through and noticed that tests you wrote before are interfering,

Check how you can resolve, or simply since no any changes your commit brings I advice u to delete this branch.

@hbapte
Copy link
Contributor Author

hbapte commented May 16, 2024

Your tests are failing. Please take a look at why

there is change in test script package.json

@hbapte hbapte closed this May 16, 2024
@hbapte hbapte deleted the chore-setup-unit-testing branch May 16, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants