Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[finishes-187354198] user authentication #14

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

Mag-codes
Copy link

@Mag-codes Mag-codes commented Jun 14, 2024

Purpose

This PR enhances the login functionality of our application, ensuring users can log in using either their email and password or via Google authentication.

Changes Made

  1. Email and Password Login:

    • Implemented the ability for users to log in using their email and password.
    • Added error handling to provide feedback when login credentials are invalid.
  2. Google Authentication:

    • Included a Google login button, allowing users to authenticate using their Google account.
  3. Redirection Handling:

    • Implemented logic to redirect users back to their original page after logging in, or to the homepage ('/') if no previous page is available.

Testing Instructions

  1. Email and Password Login:

    • Enter valid email and password credentials and confirm successful login.
    • Test with invalid credentials to ensure appropriate error messages are displayed.
  2. Google Authentication:

    • Click the "Continue with Google" button and complete the Google login process.
    • Verify that the user is redirected back to the application with successful authentication.
  3. Redirection Handling:

    • Access a protected route while not logged in, which should redirect to the login page.
    • After logging in, verify that you are redirected back to the originally intended route.
    • If no prior route is available, ensure the user is redirected to the homepage ('/').

image

@Mag-codes Mag-codes requested review from hozayves, Favor-star and niyontwali and removed request for hozayves June 14, 2024 14:06
Copy link

netlify bot commented Jun 14, 2024

Deploy Preview for e-commerce-mavericks-fn ready!

Name Link
🔨 Latest commit 861222e
🔍 Latest deploy log https://app.netlify.com/sites/e-commerce-mavericks-fn/deploys/666c57227568cc0008d73ccd
😎 Deploy Preview https://deploy-preview-14--e-commerce-mavericks-fn.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Mag-codes Mag-codes requested a review from patrickhag June 14, 2024 14:06
@Mag-codes Mag-codes force-pushed the 187354198-ft-user-authentication branch from 3a233e4 to a9515c8 Compare June 14, 2024 14:13
Copy link
Contributor

@Favor-star Favor-star left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they are working that's fine. But could you please consider adding SIGN IN with google on sign up page too?

@Mag-codes Mag-codes force-pushed the 187354198-ft-user-authentication branch from a9515c8 to 57e2127 Compare June 14, 2024 14:34
@Mag-codes Mag-codes force-pushed the 187354198-ft-user-authentication branch from 57e2127 to 5d80884 Compare June 14, 2024 14:40
@Mag-codes Mag-codes force-pushed the 187354198-ft-user-authentication branch from 5d80884 to 861222e Compare June 14, 2024 14:43
@niyontwali niyontwali merged commit 435fd4f into develop Jun 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants