Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-ui Navbar ui design bug fix #13

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

hozayves
Copy link
Contributor

Purpose

The objective of this design is to address bugs by ensuring that the navbar remains fixed upon scrolling, making it responsive, and fixing an issue where clicking on the overlay hides the side navigation.

Changes Made

Modifications were made to the navbar components.

Testing Instructions

List all testing instruction, if availbale

Related Issues

Lists all related issues

Checklist

Please review the following checklist and make sure all tasks are complete before submitting:

  • Code follows the project's coding standards
  • Changes are covered by tests
  • Documentation is updated (if applicable)
  • All tests pass

Copy link

netlify bot commented Jun 12, 2024

Deploy Preview for e-commerce-mavericks-fn ready!

Name Link
🔨 Latest commit 6f3c718
🔍 Latest deploy log https://app.netlify.com/sites/e-commerce-mavericks-fn/deploys/6669e2f37ac7ae00080db2db
😎 Deploy Preview https://deploy-preview-13--e-commerce-mavericks-fn.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hozayves hozayves force-pushed the navbar-design-fix-bug branch from 005b588 to e3b48d9 Compare June 12, 2024 15:35
Copy link
Contributor

@Favor-star Favor-star left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hozayves hozayves force-pushed the navbar-design-fix-bug branch from e3b48d9 to 6f3c718 Compare June 12, 2024 18:03
Copy link

@Mag-codes Mag-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niyontwali niyontwali merged commit 100a3a2 into develop Jun 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants