Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add qos_metrics, scheduling, notifications to GET connection request #341

Merged
merged 14 commits into from
Oct 23, 2024
Merged

Add qos_metrics, scheduling, notifications to GET connection request #341

merged 14 commits into from
Oct 23, 2024
+86 −22

Conversation

congwang09
Copy link
Contributor

Add qos_metrics, scheduling, notifications to GET connection request.

@coveralls
Copy link

coveralls commented Oct 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11471376043

Details

  • 47 of 50 (94.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.8%) to 56.821%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_controller/handlers/connection_handler.py 47 50 94.0%
Totals Coverage Status
Change from base Build 11406921868: 0.8%
Covered Lines: 1108
Relevant Lines: 1950
💛 - Coveralls

@YufengXin
Copy link
Collaborator

Let's close #337 together w/ this PR.

@YufengXin YufengXin merged commit 30d8616 into main Oct 23, 2024
11 checks passed
@YufengXin YufengXin deleted the add-qos_metrics-scheduling-notifications branch October 23, 2024 15:18
@YufengXin YufengXin mentioned this pull request Oct 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YufengXin YufengXin YufengXin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@congwang09 @coveralls @YufengXin