Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unnecessary installation of mongodb-shell on kytos-base image #108

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

italovalcy
Copy link
Contributor

Fix #104

Description of the change

The installation of mongodb-shell inside Kytos-base docker image does not seems necessary for the basic functionally of the Kytos container. Besides that, when trying to compile this container for target ARM64 (to run on Apple Silicon, for instance) it fails because mongodb-org-shell package is not available for this architecture (see Issue #104).

Local tests

After removing this package I executed new tests with full integration with sdx-controller, sdx-lc, etc. and all worked as expected.

Copy link
Collaborator

@lmarinve lmarinve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good morning, Italo,
Excellent!
I am updating you on a new development that should streamline our work with the OXPO topology conversion and provisioning.

We have established a new repository that exclusively houses the necessary functions for validating OXPO topology and transforming it into the SDX topology API wrapper. This focused approach allows us to enhance the efficiency and maintainability of our codebase.
In this repository, we will be phasing out any extra functions that don't directly support these core processes. Here is the link to the new repository: atlanticwave-sdx/sdx-oxp-integrator#9

We will also provide the /topology and /connection APIs through Nginx and document them with Swagger's OpenAPI based on the data model schema.

Italo, your expertise is crucial to us. Please take a moment to review the repository and share your thoughts. Your feedback is not only important, but it's also invaluable as we continue to progress with this initiative.

@italovalcy
Copy link
Contributor Author

Good morning, Italo, Excellent! I am updating you on a new development that should streamline our work with the OXPO topology conversion and provisioning.

We have established a new repository that exclusively houses the necessary functions for validating OXPO topology and transforming it into the SDX topology API wrapper. This focused approach allows us to enhance the efficiency and maintainability of our codebase. In this repository, we will be phasing out any extra functions that don't directly support these core processes. Here is the link to the new repository: atlanticwave-sdx/oxpo-api-wrapper#9

We will also provide the /topology and /connection APIs through Nginx and document them with Swagger's OpenAPI based on the data model schema.

Italo, your expertise is crucial to us. Please take a moment to review the repository and share your thoughts. Your feedback is not only important, but it's also invaluable as we continue to progress with this initiative.

Hi @lmarinve thanks for your comment and suggestion of the new repo. I will definitely take a look. Regarding this PR specifically, do you have any specific change or doubt you want to point out?

Copy link
Collaborator

@lmarinve lmarinve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am applying this change in the new oxpo-api-wrapper repository

@lmarinve lmarinve merged commit 3c7a340 into main Apr 22, 2024
@lmarinve lmarinve deleted the fix/issue_104 branch April 22, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mongodb-org-shell unnecessary inside kytos_base Dockerfile and fails to compile on ARM64 targets
2 participants