Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable v3 documentation rendering #797

Merged
merged 12 commits into from
Oct 5, 2023

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Oct 3, 2023

Description
This PR enables documentation for v3 documents

Related issue(s)

Blocked by #796
Blocked by asyncapi/parser-js#861
Blocked by asyncapi/asyncapi-react#808
Fixes #790

@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2023

⚠️ No Changeset found

Latest commit: 076812a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit 076812a
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/651e8c3dff366b0009861e29
😎 Deploy Preview https://deploy-preview-797--modest-rosalind-098b67.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit 076812a
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/651e8c3de32a4c0008534f63
😎 Deploy Preview https://deploy-preview-797--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jonaslagoni jonaslagoni marked this pull request as draft October 3, 2023 14:53
@jonaslagoni jonaslagoni marked this pull request as ready for review October 4, 2023 11:32
@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 16 Code Smells

No Coverage information No Coverage information
1.1% 1.1% Duplication

Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonaslagoni
Copy link
Member Author

Thanks @KhudaDad414 👍

@jonaslagoni
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 7fd77f8 into asyncapi:master Oct 5, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable documentation panel
3 participants