-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce the turborepo to the parser.js #992
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Deliverables:
|
@smoya please review the pr. |
/dnm |
Blocking the merge until we review it |
README.md
Outdated
@@ -1,533 +1,81 @@ | |||
[![AsyncAPI JavaScript Parser](./assets/logo.png)](https://www.asyncapi.com) | |||
# Turborepo starter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a proper README. This is just a placeholder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added the readme.
apps/parser/LICENSE
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should go in the root of the repository
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added in root.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You didn't move it but duplicated
@smoya It is working fine now. I changed the version and now it is working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀🌔
@ayushnau There is an error, seems a not updated .lock file or similar https://github.com/asyncapi/parser-js/actions/runs/9291475481/job/25618079508?pr=992 |
@smoya updated can you check now. |
There is an issue with our tests in CI when running under macos. It is not the first time we find this. |
We can't merge this PR until #1001 gets solved. Working on it. |
Quality Gate passedIssues Measures |
@smoya please check i have updated the pr. |
@jonaslagoni can you give your 👍 now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smoya if you are happy with it, go for it 👍 Dont see anything from my side
I only have one concern. I want to merge this ASAP and release it (so we can be sure everything works as expected, including CI pipeline etc). The point is that this is a Any idea or suggestion @jonaslagoni ? |
I think it's fine regardless, do what is easiest don't think too much about it 🙂 |
I'm gonna merge this as a new minor version ( |
/rtm |
🎉 This PR is included in version 3.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Well, failed fast 😆
See https://github.com/asyncapi/parser-js/actions/runs/9413515248/job/25930521532#step:9:65 @ayushnau I believe you tested this as per your previous comments (to publish to your own NPM account). Anyway, we need to fix this asap as `3.1.0 published in GH is also wrong, since it is a release of the whole repo not the individual app(s). Btw, I removed such tags and release from GH. |
The issue comes with semantic-release and it's lack of support for monorepo. We should move into Changesets as Studio did: https://github.com/asyncapi/studio/blob/master/doc/adr/0002-use-changesets-for-publishing-and-versioning.md I'm reverting this PR. @ayushnau Feel free to open a new one with a version that really releases each package individually. |
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes Added.
Related issue(s)
Related to: #963