-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make parameter type of ToEnum extension methods dynamic #2064
fix: make parameter type of ToEnum extension methods dynamic #2064
Conversation
✅ Deploy Preview for modelina canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to update test npm run test:update
🙂
Hi @jonaslagoni, Running npm run test:update results in all the snapshots being updated, which seems incorrect: |
I have seen this before, but I cant remember what did it. Think I cleared cache and installed dependencies again 🤔 |
I cleaned my node_modules folder, cleared the cache and ran an npm install, but I still get the same result. Anything else I could try? |
What node version are you using? 🤔 |
@jespitae try downgrade to v18 and clear cache, that is what I am currently using. |
Hey, |
@jespitae i am gonna try pull your changes and see if i get the same problem. Will do it later tonight ✌️ |
Finally had some time to sit down and try and reproduce it. What system are you using @jespitae? Windows? That is where I can reproduce it. |
Looks like I have found a "bug" in the core of the Modelina models... How the hell that bug has not explicitly shown up before puzzles me... It looks like a small discrepancy between windows and linux/mac node/typescript/npm something that makes it show up there 🤨 |
Indeed it's on windows. |
@jespitae can you try update your branch with the latest next branch? |
b188a3a
into
asyncapi:dynamic-enum-csharp
@jespitae I am gonna quickly fix it and merge it in another branch. Thanks for taking the time and sorry for the long time it took. |
@all-contributors please add @jespitae for code, bug |
I've put up a pull request to add @jespitae! 🎉 |
…2089) * fix: make parameter type of ToEnum extension methods dynamic (#2064) Co-authored-by: jespitae <[email protected]> Co-authored-by: Jens Spitaels <[email protected]>
Description
Changed parameter type of ToEnum extension methods to dynamic.
Related Issue
fixes #2063
Checklist
npm run lint
).npm run test
).Additional Notes