feat: add --pyDantic to cli for Python and Pydantic preset #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pike
requested review from
magicmatatjahu,
jonaslagoni,
kennethaasan and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for modelina canceled.
|
Pike
force-pushed
the
add-pydantic-preset
branch
from
0987b4a
to
2120e09
Compare
Pike
changed the title
Pike
changed the title
jonaslagoni
requested changes
Jun 21, 2024
There was a problem hiding this comment.
Make sure you add a new test for python with the new flag 🙂 https://github.com/Pike/modelina/blob/2120e093b34e0a8d61dcebc4b9c3e2d8a4f3db40/modelina-cli/test/integration/generate.test.ts#L119
jonaslagoni
approved these changes
Jun 22, 2024
|
@all-contributors please add @Pike for code, test |
|
I've put up a pull request to add @Pike! 🎉 |
|
🎉 This PR is included in version 4.0.0-next.52 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an option to the modelina CLI to enable the PYDANTIC preset for Python output.
Related Issue
Checklist
npm run lint).npm run test).Additional Notes