Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export AbstractDependencyManager to allow override #2044

Merged
merged 1 commit into from
Jun 17, 2024
Merged

feat: export AbstractDependencyManager to allow override #2044

merged 1 commit into from
Jun 17, 2024

Conversation

kamaz
Copy link
Contributor

@kamaz kamaz commented Jun 17, 2024 •
edited by jonaslagoni
Loading

Description

Add an export statement for AbstractDependencyManager in the index.ts file.

Related Issue

Fixes #2005

Checklist

  • The code follows the project's coding standards and is properly linted (npm run lint).
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated to reflect the changes.
  • All tests pass successfully locally.(npm run test).

Additional Notes

github-actions[bot]
github-actions bot reviewed Jun 17, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@netlify Netlify
Copy link

netlify bot commented Jun 17, 2024 •
edited
Loading

✅ Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit 1767c7c
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/6670096a1534aa0008aade54

@coveralls
Copy link

coveralls commented Jun 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9545737426

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 92.304%
Totals Coverage Status
Change from base Build 9483170018: 0.001%
Covered Lines: 5997
Relevant Lines: 6328
💛 - Coveralls

jonaslagoni
jonaslagoni approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time @kamaz ✌️

@jonaslagoni jonaslagoni merged commit c074122 into asyncapi:master Jun 17, 2024
26 checks passed
@jonaslagoni
Copy link
Member

@all-contributors please add @kamaz for code

@allcontributors allcontributors bot mentioned this pull request Jun 17, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@jonaslagoni

I've put up a pull request to add @kamaz! 🎉

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@jonaslagoni jonaslagoni jonaslagoni approved these changes

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@kennethaasan kennethaasan Awaiting requested review from kennethaasan kennethaasan is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] export AbstractDependencyManager to allow overriding
4 participants
@kamaz @coveralls @jonaslagoni @asyncapi-bot