Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(website): improve the example display name #1432

Merged
merged 2 commits into from
Jul 11, 2023
Merged

chore(website): improve the example display name #1432

merged 2 commits into from
Jul 11, 2023

Conversation

aryanas159
Copy link
Contributor

@aryanas159 aryanas159 commented Jul 7, 2023 •
edited by jonaslagoni
Loading

Description
Improved the example display names on the examples page by making a function to modify the string.

Related issue(s)

Screenshot 2023-07-07 200215
Screenshot 2023-07-07 201545

Resolves #1417

@netlify
Copy link

netlify bot commented Jul 7, 2023 •
edited
Loading

✅ Deploy Preview for modelina ready!

Name Link
🔨 Latest commit 0b41109
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/64adc30f6ce2470008c64c28
😎 Deploy Preview https://deploy-preview-1432--modelina.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot]
github-actions bot reviewed Jul 7, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

sambhavgupta0705
sambhavgupta0705 approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@sambhavgupta0705 sambhavgupta0705 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sambhavgupta0705
Copy link
Member

@aryanas159 let @jonaslagoni come back then we will merge it

@coveralls
Copy link

coveralls commented Jul 10, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5524832967

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.192%
Totals Coverage Status
Change from base Build 5524803382: 0.0%
Covered Lines: 5259
Relevant Lines: 5562
💛 - Coveralls

jonaslagoni
jonaslagoni approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks @aryanas159 💪

@jonaslagoni jonaslagoni changed the title docs: Issue #1417 - Improved the example display name chore(website): improve the example display name Jul 11, 2023
@jonaslagoni jonaslagoni merged commit d1c7c1f into asyncapi:master Jul 11, 2023
@jonaslagoni
Copy link
Member

@all-contributors please add @aryanas159 for code

@allcontributors allcontributors bot mentioned this pull request Jul 11, 2023
Merged
@allcontributors
Copy link
Contributor

@jonaslagoni

I've put up a pull request to add @aryanas159! 🎉

@sonarcloud
Copy link

sonarcloud bot commented Jul 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.8.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@sambhavgupta0705 sambhavgupta0705 sambhavgupta0705 approved these changes

@jonaslagoni jonaslagoni jonaslagoni approved these changes

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu

@kennethaasan kennethaasan Awaiting requested review from kennethaasan

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the example display name
5 participants
@aryanas159 @sambhavgupta0705 @coveralls @jonaslagoni @asyncapi-bot