Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(website): add C# options descriptions in the playground #1415

Merged

Conversation

codingmickey
Copy link
Contributor

Part of Add descriptions for options in playground continued.. #1392

@netlify
Copy link

netlify bot commented Jun 18, 2023

Deploy Preview for modelina ready!

Name Link
🔨 Latest commit e84b810
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/64920b75f1c81d000700a660
😎 Deploy Preview https://deploy-preview-1415--modelina.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Part of Add descriptions for options in playground continued.. asyncapi#1392

Signed-off-by: Kartik Jolapara <[email protected]>
@codingmickey codingmickey force-pushed the fix-1392/Add-C#-Option-descriptions branch from 6db3d00 to eba3712 Compare June 18, 2023 19:50
@jonaslagoni jonaslagoni changed the title fix: Add C# options descriptions in the playground chore(website): add C# options descriptions in the playground Jun 19, 2023
@jonaslagoni
Copy link
Member

Anything related to website changes, remember to use chore(website) 🙂

@coveralls
Copy link

coveralls commented Jun 19, 2023

Pull Request Test Coverage Report for Build 5315111479

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.192%

Totals Coverage Status
Change from base Build 5326165915: 0.0%
Covered Lines: 5259
Relevant Lines: 5562

💛 - Coveralls

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some spacing issues and the strong component does not render the text any different, you might want to switch to something else 🤔

Also, all your titles are using Package Name : instead of a specific one 🙂

Other then that the text looks good 👍

@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonaslagoni jonaslagoni merged commit 44da970 into asyncapi:master Jun 20, 2023
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.8.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants