-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(website): add C# options descriptions in the playground #1415
chore(website): add C# options descriptions in the playground #1415
Conversation
✅ Deploy Preview for modelina ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Part of Add descriptions for options in playground continued.. asyncapi#1392 Signed-off-by: Kartik Jolapara <[email protected]>
6db3d00
to
eba3712
Compare
Anything related to website changes, remember to use |
Pull Request Test Coverage Report for Build 5315111479
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is some spacing issues and the strong
component does not render the text any different, you might want to switch to something else 🤔
Also, all your titles are using Package Name :
instead of a specific one 🙂
Other then that the text looks good 👍
modelina-website/src/components/playground/options/CSharpGeneratorOptions.tsx
Outdated
Show resolved
Hide resolved
modelina-website/src/components/playground/options/CSharpGeneratorOptions.tsx
Outdated
Show resolved
Hide resolved
modelina-website/src/components/playground/options/CSharpGeneratorOptions.tsx
Outdated
Show resolved
Hide resolved
+ text in the header of the modal Signed-off-by: Kartik Jolapara <[email protected]>
…escription Signed-off-by: Kartik Jolapara <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
🎉 This PR is included in version 1.8.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Part of Add descriptions for options in playground continued.. #1392