Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(website): add info for java options #1411

Merged

Conversation

SumantxD
Copy link
Contributor

this PR tries to add info for the java specific options as mentioned in the issue #1392

@netlify
Copy link

netlify bot commented Jun 15, 2023

Deploy Preview for modelina ready!

Name Link
🔨 Latest commit 0153a11
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/6496f1603451330008be5909
😎 Deploy Preview https://deploy-preview-1411--modelina.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@coveralls
Copy link

coveralls commented Jun 15, 2023

Pull Request Test Coverage Report for Build 5364597704

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.192%

Totals Coverage Status
Change from base Build 5327605616: 0.0%
Covered Lines: 5259
Relevant Lines: 5562

💛 - Coveralls

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a few comments 👍 Otherwise it looks good 😄

@SumantxD
Copy link
Contributor Author

@jonaslagoni sorry for the delay, i was busy with a bunch of other stuffs and lost track of this issue 😅
I have tried fixing the requested changes, 😄

@sonarcloud
Copy link

sonarcloud bot commented Jun 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonaslagoni jonaslagoni changed the title chore: fix-1392 added info for java specific options chore(website): add info for java options Jun 24, 2023
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @SumantxD 👌

@jonaslagoni jonaslagoni merged commit 23af101 into asyncapi:master Jun 24, 2023
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.8.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants