fix: csharp serializer incorrectly handles unwrappable dictionaries (#…

…1483)
asyncapi · Aug 22, 2023 · eb7dd62 · eb7dd62
1 parent 627ed97
commit eb7dd62
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 12 deletions.
diff --git a/src/generators/csharp/presets/JsonSerializerPreset.ts b/src/generators/csharp/presets/JsonSerializerPreset.ts
@@ -50,12 +50,13 @@ if (${modelInstanceVariable} != null) {
     ${renderSerializeProperty('unwrappedProperty.Value', propertyModel)}
   }
 }`;
-      }
-      serializeProperties += `if(${modelInstanceVariable} != null) {
+      } else {
+        serializeProperties += `if(${modelInstanceVariable} != null) {
   // write property name and let the serializer serialize the value itself
   writer.WritePropertyName("${propertyModel.unconstrainedPropertyName}");
   ${renderSerializeProperty(modelInstanceVariable, propertyModel)}
 }\n`;
+      }
     }
   }
   return serializeProperties;

diff --git a/test/generators/csharp/presets/__snapshots__/JsonSerializerPreset.spec.ts.snap b/test/generators/csharp/presets/__snapshots__/JsonSerializerPreset.spec.ts.snap
@@ -147,13 +147,8 @@ internal class TestConverter : JsonConverter<Test>
         writer.WritePropertyName(unwrappedProperty.Key);
         JsonSerializer.Serialize(writer, unwrappedProperty.Value, options);
       }
-    }if(value.AdditionalProperties != null) {
-      // write property name and let the serializer serialize the value itself
-      writer.WritePropertyName(\\"additionalProperties\\");
-      JsonSerializer.Serialize(writer, value.AdditionalProperties, options);
     }
 
-
     writer.WriteEndObject();
   }
 
@@ -292,13 +287,8 @@ internal class NestedTestConverter : JsonConverter<NestedTest>
         writer.WritePropertyName(unwrappedProperty.Key);
         JsonSerializer.Serialize(writer, unwrappedProperty.Value, options);
       }
-    }if(value.AdditionalProperties != null) {
-      // write property name and let the serializer serialize the value itself
-      writer.WritePropertyName(\\"additionalProperties\\");
-      JsonSerializer.Serialize(writer, value.AdditionalProperties, options);
     }
 
-
     writer.WriteEndObject();
   }