Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove alternate identifier #643

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

ManonMarchand
Copy link
Member

Some alternate identifiers were related to similar datasets but not exactly equivalent ones in some VizieR entries.

With the evolution of the description of doi and bibcode, these identifiers have been moved into the section isRelatedTo and removed from alternateIdentifier in the CDS registry.

This change has been caught by pyVO's CI but is not a bug.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.30%. Comparing base (f765128) to head (3f84289).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #643   +/-   ##
=======================================
  Coverage   82.30%   82.30%           
=======================================
  Files          72       72           
  Lines        7430     7430           
=======================================
  Hits         6115     6115           
  Misses       1315     1315           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bsipocz bsipocz added this to the v1.6.1 milestone Jan 24, 2025
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Manon!

@bsipocz bsipocz merged commit 50d3e7a into astropy:main Jan 24, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants