MAINT: drop python 3.8 support #639
Open
+145
−152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsipocz
force-pushed
the
MAINT_drop_python38
branch
from
46ad049 to
cdb4a32
Compare
|
Thanks for going through this! I'd vote to keep python 3.9 until its end of life (this October) if possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops python 3.8 support. I also run pyupgrade to cleanup code, and accepted most of the changes into the second commit. I feel it indeed become cleaner by switching to use fstrings, but please let me know if you dislike this and I'm happy to drop the commit or to tune it back to a smaller collection of changes.
Python 3.9 is not yet EOL, but it is also close to it, so we could in fact drop that one, too.
[edit]: This also bumps minimum astropy to 4.2, as prior versions didn't support python 3.9