Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: ignoring IERS warnings #637

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Jan 9, 2025

Workaround to pass the old python tests: there are no updates for these, so the workaround is to ignore these warnings while we support python 3.8. Alternatively, we could ignore these warnings by default as I don't think they ever have any actual effect on pyvo functionality.

This should fix the python 3.8 job failure

Copy link
Contributor

@msdemlei msdemlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale IERS data indeed is irrelevant for pyVO; I'd hope one of these days we'll do some smart stuff with TIMESYS or, gasp, proper STC annotation, but by this day I'm afraid python 3.8 will feel like the venerable 1.54 feels to us now.

Ah, except we still have related warnings. The failures we get in some tests from ERFA look a lot like what it would do if it has not got up-to-date IERS data. So, I'm not merging and would suggest to ignore these warnings, too.

@bsipocz
Copy link
Member Author

bsipocz commented Jan 9, 2025

I'm adding the ErfaWarning ignore in, too.

FWIW, I'm totally open for dropping 3.8 for pyvo1.7, a lot of libraries in fact are already on 3.11+. But this PR will be still handy if we have a 1.6.1 bugfix release before that.

@bsipocz bsipocz force-pushed the MAINT_add_warning_ignore branch 2 times, most recently from 75292b2 to e572a4d Compare January 9, 2025 20:49
@bsipocz bsipocz force-pushed the MAINT_add_warning_ignore branch from e572a4d to 890b990 Compare January 10, 2025 02:20
@bsipocz
Copy link
Member Author

bsipocz commented Jan 10, 2025

The remaining failures should be addressed by #636, so I go ahead and merge this now.

@bsipocz bsipocz merged commit 69f3c2b into astropy:main Jan 10, 2025
9 of 11 checks passed
@bsipocz bsipocz deleted the MAINT_add_warning_ignore branch January 10, 2025 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants