Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: adding remote reaching TAP upload tests #631

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Dec 10, 2024

As promised in #626 (comment), I'm adding two simple tests doing TAP uploads to the ALMA server. The code is copied from astroquery, but it runs really fast and test two simple scenarios, so I think it has some value in our test suite.

The PR also fixes a doctest that started failing recently.

@bsipocz bsipocz added this to the v1.6.1 milestone Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.31%. Comparing base (d5df951) to head (98a1710).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #631   +/-   ##
=======================================
  Coverage   82.31%   82.31%           
=======================================
  Files          72       72           
  Lines        7429     7429           
=======================================
  Hits         6115     6115           
  Misses       1314     1314           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@msdemlei msdemlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once Paris is back on the list, let's go. Thanks!

@@ -602,7 +602,6 @@ RegTAP services using:
... for r in res)))
http://dc.zah.uni-heidelberg.de/tap
http://gavo.aip.de/tap
http://voparis-rr.obspm.fr/tap
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That paris fell out here was an accident. It's back again, so please undo this edit.

@bsipocz bsipocz force-pushed the TST_adding_more_tests branch from 7f68019 to 98a1710 Compare December 11, 2024 18:34
@bsipocz bsipocz merged commit b3dec37 into astropy:main Dec 11, 2024
13 checks passed
@bsipocz bsipocz deleted the TST_adding_more_tests branch December 11, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants