BUG: cleanup finally-returns #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msdemlei
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
I have briefly tried to understand why the original author did the try-finally construct here in the first place, but I'm fairly confident that there are no external invariants they wanted to preserve or that they consciously wanted to swallow the exception.
So, I'm merging. Thanks!
|
Actually, this has causing a regression for the NAVO notebooks while doing some HEASARC queries. I don't say this PR is wrong, but clearly there are more bugs somewhere. (And due to some blacklists/etc I cannot debug this right now, so would just do the 1.6 branching before this PR and leave this to get fully sorted in either 1.6.1 or in 1.7) |
This was referenced Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #612
Note, changelog CI check is expected to fail with the milestone check, follow-up PR to change logic is to come for that