-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding RegistryResults and RegistryResource to the registry API #608
Conversation
Oh, there is a CI failure we might want to fix while we're at it:
I am a bit surprised that a resource vanishes here (apparently, its spatial coverage changed), but that new resources come up here is fairly expectable. if the matching language is rich enouch, I'd say "make sure ivo://cds.vizier/j/a+a/688/a104 is in the list" would be fine, else perhaps we should ignore the output? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #608 +/- ##
==========================================
+ Coverage 81.70% 81.85% +0.15%
==========================================
Files 69 70 +1
Lines 7093 7160 +67
==========================================
+ Hits 5795 5861 +66
- Misses 1298 1299 +1 ☔ View full report in Codecov by Sentry. |
We should be able to do a partial matching with an ellipse after the first result line. If that doesn't work, |
@@ -15,4 +15,5 @@ | |||
"Freetext", "Author", | |||
"Servicetype", "Waveband", "Datamodel", "Ivoid", "UCD", | |||
"Spatial", "Spectral", "Temporal", | |||
"choose_RegTAP_service", "RegTAPFeatureMissing"] | |||
"choose_RegTAP_service", "RegTAPFeatureMissing", | |||
"RegistryResults", "RegistryResource",] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These need to be imported, too.
And that should fix the traceback in the docs build.
Ignore the changelog and milestone check statuses, I'm still thinking about which release to put this in and if it can be joined with other API cleanup PRs. |
1a11cb2
to
37c6a93
Compare
This has been found necessary in the context of global discovery, but since users are actually handling instances of these classes quite a bit, it seems wise to bless them as parts of the API.
37c6a93
to
4706df9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Markus!
This has been found necessary in the context of global discovery (PR #470), but since users are actually handling instances of these classes quite a bit, it seems wise to bless them as parts of the API.