BUG: Include port number if present #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsipocz
reviewed
Aug 5, 2024
bsipocz
reviewed
Oct 1, 2024
bsipocz
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #582 +/- ##
==========================================
+ Coverage 81.68% 81.70% +0.01%
==========================================
Files 69 69
Lines 7089 7093 +4
==========================================
+ Hits 5791 5795 +4
Misses 1298 1298 ☔ View full report in Codecov by Sentry. |
bsipocz
approved these changes
Oct 1, 2024
pyvo/dal/vosi.py
Outdated
| endpoint=endpoint), | ||
|
|
||
| return [ | ||
| '{baseurl}/{endpoint}'.format(baseurl=curated_baseurl, endpoint=endpoint), |
pyvo/dal/vosi.py
Outdated
| netloc = urlcomp.hostname | ||
| if urlcomp.port: | ||
| netloc += f':{urlcomp.port}' | ||
| curated_baseurl = '{}://{}{}'.format(urlcomp.scheme, netloc, urlcomp.path) |
There was a problem hiding this comment.
An fstring would be more readable I think.
|
Failures are upstream server and unrelated. |
bsipocz
added a commit
that referenced
this pull request
Oct 14, 2024
BUG: Include port number if present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix to address the Issue #563, by including the port number if present
in the provided URL.
The code checks if the
baseurlhas port number, and adds to the hostname incurated_baseurl.This should fix the issue that the port number was missing as #563 described.