Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roles: Move general maintainers in same section as sub-package maintainers #614

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

pllim
Copy link
Member

@pllim pllim commented Aug 10, 2024

In #475 , there is no explanation why they couldn't be in the same section. Seems weird to have almost duplicate text as different rows. But is it allowed to have "sub-roles" and "responsibilities" not match?

https://output.circle-artifacts.com/output/job/e76af6f1-9bbd-4d0f-bb6f-02e3374ff603/artifacts/0/html/team.html

xref #519

@pllim pllim marked this pull request as ready for review August 10, 2024 00:35
@pllim pllim requested a review from hamogu August 10, 2024 00:36
Copy link
Member

@hamogu hamogu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably just because in #475 I did not understand how the json should be organized. No particular reason why it's not been done this way.

@mhvk
Copy link
Contributor

mhvk commented Aug 12, 2024

Makes sense!

maintainers

Wording tweaks

Consistent verbiage
@pllim
Copy link
Member Author

pllim commented Oct 14, 2024

Thanks for the approvals! Merging.

@pllim pllim merged commit 7f390d4 into astropy:main Oct 14, 2024
2 checks passed
@pllim pllim deleted the core-maintainer-gen branch October 14, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants