Fix #194: Simplify role-changing machinery with json and js

[apooravc]

Fixes #194

• Deleted roles.txt and update_roles.py.

• Added roles.json, an equivalent of roles.txt.

• Used some JS to populate roles table from the json file.

• Added roles descriptions to json file and created those roles lists from it.

json entry format
{
"role" : "role name",
"url" : "div element url",
"sub-role" : ["sub-role-1", "sub-role-2", "sub-role-3"],
"lead" : ["lead-1", "lead-2", "lead-3"],
"deputy" : ["deputy-1", "deputy-2", "deputy-3"],
"role-head" : ["role heading"],
"strong" : [["strong-title-1"], ["strong-title-2"]],
"sub-description" : [["sub-description-1"], ["sub-description-2"]],
"description" : ["list-item-1", "list-item-2", "list-item-3"]
}

One way to see the changes locally would be as follows:

1. Clone my repo from https://github.com/apooravc/astropy.github.com
2. After cloning, only the master branch would be available locally. Enter git checkout -b simplify-role-changing origin/simplify-role-changing to get the branch simplify-role-changing locally.
3. The changes could then be seen on team page.

@eteq Please have a look.

[eteq]

@apooravc - this is great! Thanks for taking the time to work on this. Very close to exactly what I was hoping for. I have one inline comment (see below) and one broader item:

As you've implemented it, all of the information to build the table is in the roles.json file, which is great! However, in the description section of the site still requires some changes on the HTML side: we add new roles fairly regularly, so it would be better if instead no modification to the HTML was required at all. Basically, this would mean removing all of the sections that in your version have a <br/>, <hr>...</h3>, <p>...</p>, and the <ul class="roles-list"></ul>, and instead having them be generated from javascript (using the kind of DOM manipulation you're already doing to make the roles-list). The only content that I think you have to move, then, is the part of the description that's currently inside the <p> tags.

Make sense?

(If you care about these sort of things, this is a classic example of a Model-View-Controller situation: the Model is the JSON file, the View is the HTML, and the Controller is the js file. In the current implementation, a little bit of the model is in the HTML, and I'm suggesting we move it entirely out into the JSON)

[eteq]

Maybe modify this to not be specific to a particular index? E.g., instead of the if statement being if (index != 5) have it be if (role["description"].length == 2 & role["description"][0] instanceof Array)? (if you use that if you'll have to swap the if and else blocks, but hopefully you get the idea?)

[eteq]

(One other minor suggestion for the future @apooravc : usually it's best to have commit messages be more specific than "fix". For example, instead of "Third fix for #194" you might say "added urls to javascript-generated table". No change needed, but just something to keep in mind for the future.)

[apooravc]

@eteq Did the required changes, please have a look.

[eteq]

Thanks @apooravc! I think it looks great, but I saw just a couple minor things that might make things a bit easier to maintain down the road. But ones those are fixed I think we are all set!

[eteq]

this regExp variable could have a slightly clearer name - I was trying to understand and it took me a while to realize it was the "deputy" part. Maybe call it regExpPreferDeputy or similar?

[eteq]

I think the description and sub-description or swapped here. What you have as sub-description seem to be the more minor items, whereas description are the big things. Maybe just swap the two?

[eteq]

With a day to think I realized I could just do those minor changes myself. So this is all set and I will merge it shortly. Thanks @apooravc !