Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify role-changing machinery with json and js #194

Closed
3 tasks
eteq opened this issue Sep 28, 2017 · 1 comment
Closed
3 tasks

Simplify role-changing machinery with json and js #194

eteq opened this issue Sep 28, 2017 · 1 comment

Comments

@eteq
Copy link
Member

eteq commented Sep 28, 2017

Right now it's a bit awkwardly complicated to update the roles - you have to update a special-format roles.txt file, and then run a script locally and remember to commit both with git. That works for now, but A better system might be to:

  • change roles.txt to a roles.json file
  • use code like what we have in the affiliated package page to populate a table from the JSON using a javascript function (which would run locally and is very fast - this has been in practice very stable/easy on the affilaited/index.html).
  • include the roles descriptions in theroles.json as well - then do a bit more js tricks to get the roles list to appear on the web site.

Once these are all done, it'll be easy to update the roles in a single commit rather than the awkward 2- or 3- stage process currently required (which also requires knowing to run the script).

Also #167 could be much more easily addressed with this all in place - there could be an additional json field for past holders of the role, and the js could include that at the bottom of the page or something.

@eteq eteq changed the title Simplify roles machinery Simplify role-changing machinery with json and js Sep 28, 2017
@apooravc
Copy link
Contributor

@eteq Working on it.

apooravc added a commit to apooravc/astropy.github.com that referenced this issue Feb 20, 2018
apooravc added a commit to apooravc/astropy.github.com that referenced this issue Feb 20, 2018
apooravc added a commit to apooravc/astropy.github.com that referenced this issue Feb 20, 2018
apooravc added a commit to apooravc/astropy.github.com that referenced this issue Mar 11, 2018
@eteq eteq closed this as completed in #225 Mar 20, 2018
eteq added a commit that referenced this issue Mar 20, 2018
Fix #194: Simplify role-changing machinery with json and js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants