Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS to track all files #276

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Update CODEOWNERS to track all files #276

merged 2 commits into from
Oct 28, 2024

Conversation

pankajkoti
Copy link
Contributor

The first argument in the CODEOWNERS file tells what all files to monitor for changes. Since, we din't specify any file, the code review requests are not getting sent. Specifying the wild card asterisk tells it to monitor for all files in the repo & accordingly work for the CODEOWNERS features such as sending review requests to the CODEOWNERS upon opening pull requests.

The first argument in the CODEOWNERS file tells what all files to monitor for changes. Since, we din't specify any file, the code review requests are not getting sent. Specifying the wild card asterisk tells it to monitor for all files in the repo & accordingly work for the CODEOWNERS features such as sending review requests to the CODEOWNERS upon opening pull requests.
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.96%. Comparing base (644ad62) to head (fe2626a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #276   +/-   ##
=======================================
  Coverage   93.96%   93.96%           
=======================================
  Files           8        8           
  Lines         630      630           
=======================================
  Hits          592      592           
  Misses         38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CODEOWNERS Outdated Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
@tatiana tatiana merged commit 1c999f5 into main Oct 28, 2024
67 checks passed
@tatiana tatiana deleted the pankajkoti-patch-1 branch October 28, 2024 10:45
@@ -1 +1 @@
@oss-integrations
* @astronomer/oss-integrations
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, @pankajkoti ! I hadn't realised before we were missing the org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants