Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add astro cli project to run airflow+dagfactory #267

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Add astro cli project to run airflow+dagfactory #267

merged 5 commits into from
Oct 21, 2024

Conversation

pankajastro
Copy link
Contributor

@pankajastro pankajastro commented Oct 18, 2024

Summary: This PR introduces the Astro CLI project into the repository and removes the legacy Dockerfile.

Changes:

  • Added: Astro CLI project to facilitate managing the Airflow environment.
  • Removed: Legacy Dockerfile to streamline the project and avoid confusion.
  • Usage: To start the Airflow container, run the following command:
make docker-run

closes: #193

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.96%. Comparing base (55a1a2f) to head (f6f6f35).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #267   +/-   ##
=======================================
  Coverage   93.96%   93.96%           
=======================================
  Files           8        8           
  Lines         630      630           
=======================================
  Hits          592      592           
  Misses         38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
remove scripts/entrypoint.sh

Replace copy to whl build

Apply feedback

Apply feedback
Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all the feedback, @pankajastro , this is invaluable for us to validate DAG factory in Astro

@pankajastro pankajastro merged commit 5c04b0b into main Oct 21, 2024
67 checks passed
@pankajastro pankajastro deleted the cleanup branch October 21, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove legacy Dockerfile
3 participants