Try upgrading dbt-core & dbt adapters versions to see if the dependencies resolve #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.
|
pankajastro
reviewed
Oct 3, 2024
| @@ -1,4 +1,4 @@ | |||
| pip uninstall -y dbt-core dbt-sqlite openlineage-airflow openlineage-integration-common; \ | |||
| rm -rf airflow.*; \ | |||
| airflow db init; \ | |||
| pip install 'dbt-core==1.4' 'dbt-sqlite<=1.4' 'dbt-databricks<=1.4' 'dbt-postgres<=1.4' | |||
| pip install 'dbt-core==1.8' 'dbt-sqlite<=1.8' 'dbt-databricks<=1.8' 'dbt-postgres<=1.8' | |||
There was a problem hiding this comment.
Suggested change
| pip install 'dbt-core==1.8' 'dbt-sqlite<=1.8' 'dbt-databricks<=1.8' 'dbt-postgres<=1.8' | |
| pip install 'dbt-core==1.5' 'dbt-sqlite<=1.5' 'dbt-databricks<=1.5' 'dbt-postgres<=1.5' |
There was a problem hiding this comment.
Latest dbt-sqlite adaptor is 1.5 https://pypi.org/project/dbt-sqlite/#history
There was a problem hiding this comment.
yes, we specify dbt-sqlite<=1.8, so whenever a newer version is released it would be picked up & should ideally be still compatible with dbt-core==1.8. This is my rationale. WDYT?
pankajkoti
force-pushed
the
try-sqlite-with-dbt-1.8
branch
from
aab5300
to
37b26b2
Compare
|
closing in favour of #1236 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1235 +/- ##
==========================================
- Coverage 95.93% 95.90% -0.03%
==========================================
Files 67 67
Lines 3885 3885
==========================================
- Hits 3727 3726 -1
- Misses 158 159 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observed sqlite integration job failing to resolve dependencies after adding the dbt-bigquery adapter to the job in the PR #1230
Hence, try to use newer dbt-core & adapters to see if CI is able to resolve dependencies