generated from astronomer/airflow-provider-sample
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Better exception handling and cluster clean up #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venkatajagannath
temporarily deployed
to
internal
September 19, 2024 06:09
— with
GitHub Actions
Inactive
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
==========================================
+ Coverage 95.42% 96.44% +1.02%
==========================================
Files 5 5
Lines 546 563 +17
==========================================
+ Hits 521 543 +22
+ Misses 25 20 -5 ☔ View full report in Codecov by Sentry. |
venkatajagannath
temporarily deployed
to
internal
September 19, 2024 21:16
— with
GitHub Actions
Inactive
venkatajagannath
temporarily deployed
to
internal
September 21, 2024 20:02
— with
GitHub Actions
Inactive
pankajastro
reviewed
Sep 23, 2024
pankajastro
reviewed
Sep 24, 2024
venkatajagannath
temporarily deployed
to
internal
September 24, 2024 17:01
— with
GitHub Actions
Inactive
venkatajagannath
changed the title
Bugfix: Setting up on_failure_callback
Bugfix: Better exception handling and cluster clean up
Sep 24, 2024
pankajastro
reviewed
Sep 25, 2024
pankajastro
previously approved these changes
Sep 25, 2024
venkatajagannath
temporarily deployed
to
internal
September 25, 2024 08:42
— with
GitHub Actions
Inactive
venkatajagannath
force-pushed
the
on_failure_callback
branch
from
September 25, 2024 08:43
6dd9c9b
to
27a2020
Compare
venkatajagannath
temporarily deployed
to
internal
September 25, 2024 08:44
— with
GitHub Actions
Inactive
pankajastro
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug for cleaning up cluster resources when they are no longer required.
We make 2 changes --
Also added additional unit tests for both operator & trigger to ensure high code coverage.