copy connection/variable warning message (#1208)

* copy connection/variable warning message * add dag deploy enabled column * Update cmd/cloud/deployment_objects.go
astronomer · May 18, 2023 · e45a32f · e45a32f
1 parent af54f72
commit e45a32f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/cloud/deployment/deployment.go b/cloud/deployment/deployment.go
@@ -786,9 +786,9 @@ var SelectDeployment = func(deployments []astro.Deployment, message string) (ast
 	}
 
 	tab := printutil.Table{
-		Padding:        []int{5, 30, 30, 50},
+		Padding:        []int{5, 30, 30, 30, 50},
 		DynamicPadding: true,
-		Header:         []string{"#", "DEPLOYMENT NAME", "RELEASE NAME", "DEPLOYMENT ID"},
+		Header:         []string{"#", "DEPLOYMENT NAME", "RELEASE NAME", "DEPLOYMENT ID", "DAG DEPLOY ENABLED"},
 	}
 
 	fmt.Println(message)
@@ -800,7 +800,7 @@ var SelectDeployment = func(deployments []astro.Deployment, message string) (ast
 	deployMap := map[string]astro.Deployment{}
 	for i := range deployments {
 		index := i + 1
-		tab.AddRow([]string{strconv.Itoa(index), deployments[i].Label, deployments[i].ReleaseName, deployments[i].ID}, false)
+		tab.AddRow([]string{strconv.Itoa(index), deployments[i].Label, deployments[i].ReleaseName, deployments[i].ID, strconv.FormatBool(deployments[i].DagDeployEnabled)}, false)
 
 		deployMap[strconv.Itoa(index)] = deployments[i]
 	}

diff --git a/cmd/cloud/deployment_objects.go b/cmd/cloud/deployment_objects.go
@@ -28,7 +28,11 @@ var (
 	slots              int
 )
 
-const requestString = "metadata.webserver_url"
+const (
+	requestString            = "metadata.webserver_url"
+	warningConnectionCopyCMD = "WARNING! The password and extra field are not copied over. You will need to manually add these values"
+	warningVariableCopyCMD   = "WARNING! Secret values are not copied over. You will need to manually add these values"
+)
 
 func newDeploymentConnectionRootCmd(out io.Writer) *cobra.Command {
 	cmd := &cobra.Command{
@@ -422,7 +426,7 @@ func deploymentConnectionCopy(cmd *cobra.Command, out io.Writer) error {
 	}
 
 	toAirlfowURL := fmt.Sprintf("%v", value)
-
+	fmt.Println(warningConnectionCopyCMD)
 	return deployment.CopyConnection(fromAirlfowURL, toAirlfowURL, airflowAPIClient, out)
 }
 
@@ -534,6 +538,7 @@ func deploymentAirflowVariableCopy(cmd *cobra.Command, out io.Writer) error {
 
 	toAirlfowURL := fmt.Sprintf("%v", value)
 
+	fmt.Println(warningVariableCopyCMD)
 	return deployment.CopyVariable(fromAirlfowURL, toAirlfowURL, airflowAPIClient, out)
 }