-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tab width option #6848
Add tab width option #6848
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this interact with docstring formatting where we have "pad to the next multiple of 8" hardcoded?
PR Check ResultsBenchmarkLinux
Windows
|
bdd79f3
to
b81f4a7
Compare
Thanks for pointing this out. I changed the docstring padding to use the value from the options. Deviating here isn't an issue because a) people chan change the option b) this is only relevant for not blacked projects (adoption) |
b81f4a7
to
cd66e22
Compare
cd66e22
to
edfeb59
Compare
Merging because it is a simple enough change and there's other work that depends on it. |
Summary
This adds a new
tab_width
option that gets passed to the Printer. Thetab_width
option specifies the visual width of a tab character.Test Plan
I added a new test. The fact that I had to add options not to regress tests that assumed a tab width of 8 proves that it works :)