Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lexing for colon-matching use cases #6803

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Remove lexing for colon-matching use cases #6803

merged 1 commit into from
Aug 23, 2023

Conversation

charliermarsh
Copy link
Member

It's much simpler to just search ahead for the first colon.

@charliermarsh charliermarsh added the internal An internal refactor or improvement label Aug 23, 2023
@charliermarsh charliermarsh enabled auto-merge (squash) August 23, 2023 04:28
@charliermarsh charliermarsh merged commit d08f697 into main Aug 23, 2023
16 checks passed
@charliermarsh charliermarsh deleted the charlie/lex branch August 23, 2023 04:44
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.01      3.4±0.01ms    11.9 MB/sec    1.00      3.4±0.01ms    12.0 MB/sec
formatter/numpy/ctypeslib.py               1.00    713.5±2.19µs    23.3 MB/sec    1.00    716.7±2.32µs    23.2 MB/sec
formatter/numpy/globals.py                 1.00     74.8±0.28µs    39.4 MB/sec    1.04     77.9±4.33µs    37.9 MB/sec
formatter/pydantic/types.py                1.00  1398.8±22.71µs    18.2 MB/sec    1.00  1396.1±27.67µs    18.3 MB/sec
linter/all-rules/large/dataset.py          1.01     10.3±0.05ms     3.9 MB/sec    1.00     10.2±0.04ms     4.0 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.01      2.8±0.00ms     6.0 MB/sec    1.00      2.8±0.02ms     6.0 MB/sec
linter/all-rules/numpy/globals.py          1.00    390.4±0.94µs     7.6 MB/sec    1.00    389.2±0.87µs     7.6 MB/sec
linter/all-rules/pydantic/types.py         1.02      5.4±0.02ms     4.7 MB/sec    1.00      5.3±0.02ms     4.8 MB/sec
linter/default-rules/large/dataset.py      1.01      5.5±0.02ms     7.4 MB/sec    1.00      5.5±0.01ms     7.5 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.01   1227.4±1.80µs    13.6 MB/sec    1.00   1217.1±2.25µs    13.7 MB/sec
linter/default-rules/numpy/globals.py      1.01    141.8±0.26µs    20.8 MB/sec    1.00    140.9±2.24µs    20.9 MB/sec
linter/default-rules/pydantic/types.py     1.01      2.5±0.01ms    10.2 MB/sec    1.00      2.5±0.00ms    10.3 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      3.7±0.05ms    11.0 MB/sec    1.02      3.8±0.06ms    10.8 MB/sec
formatter/numpy/ctypeslib.py               1.00   759.4±11.58µs    21.9 MB/sec    1.02   771.2±13.29µs    21.6 MB/sec
formatter/numpy/globals.py                 1.00     78.3±1.90µs    37.7 MB/sec    1.02     80.2±2.22µs    36.8 MB/sec
formatter/pydantic/types.py                1.00  1534.2±25.34µs    16.6 MB/sec    1.02  1572.1±84.49µs    16.2 MB/sec
linter/all-rules/large/dataset.py          1.01     13.1±0.19ms     3.1 MB/sec    1.00     13.0±0.20ms     3.1 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.01      3.6±0.12ms     4.6 MB/sec    1.00      3.5±0.06ms     4.7 MB/sec
linter/all-rules/numpy/globals.py          1.00   436.7±13.15µs     6.8 MB/sec    1.00    434.6±8.77µs     6.8 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.9±0.18ms     3.7 MB/sec    1.00      6.8±0.14ms     3.7 MB/sec
linter/default-rules/large/dataset.py      1.00      7.2±0.10ms     5.7 MB/sec    1.00      7.2±0.09ms     5.6 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.01  1540.7±22.04µs    10.8 MB/sec    1.00  1532.1±24.36µs    10.9 MB/sec
linter/default-rules/numpy/globals.py      1.00    176.5±2.92µs    16.7 MB/sec    1.00    177.2±6.64µs    16.7 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.2±0.04ms     7.9 MB/sec    1.02      3.3±0.07ms     7.8 MB/sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant