[red-knot] Simplify some traits in ast_ids.rs
#14379
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Another small cleanup I'm splitting out from the branch I have locally working towards #13933. The traits
HasScopedUseId
andHasScopedAstId
don't need to be generic: for both traits, theId
associated type is the same for all implementations of the trait. We can remove some complexity here by removing the associated types and specifying concrete types in the trait definitions rather than associated types.Test Plan
cargo test -p red_knot_python_semantic