Split the corpus tests into smaller tests #14367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
requested review from
carljm,
AlexWaygood and
sharkdp
as code owners
MichaReiser
added
testing
MichaReiser
force-pushed
the
micha/split-corpus-tests
branch
from
2f0d92b
to
9ae89b4
Compare
MichaReiser
changed the title
|
carljm
approved these changes
Nov 15, 2024
dylwil3
pushed a commit
to dylwil3/ruff
that referenced
this pull request
Nov 17, 2024
## Summary This PR splits the corpus tests into smaller chunks because running all of them takes 8s on my windows machine and it's by far the longest test in `red_knot_workspace`. Splitting the tests has the advantage that they run in parallel. This PR brings down the wall time from 8s to 4s. This PR also limits the glob for the linter tests because it's common to clone cpython into the `ruff_linter/resources/test` folder for benchmarks (because that's what's written in the contributing guides) ## Test Plan `cargo test`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR splits the corpus tests into smaller chunks because running all of them takes 8s on my windows machine and it's by far the longest test in
red_knot_workspace.Splitting the tests has the advantage that they run in parallel. This PR brings down the wall time from 8s to 4s.
This PR also limits the glob for the linter tests because it's common to clone cpython into the
ruff_linter/resources/testfolder for benchmarks (because that's what's written in the contributing guides)Test Plan
cargo test