Remove the optional salsa dependency from the AST crate #14363
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I added the
Lookup
implementation toName
to allowClass
andFunctionType
lookups with a&str
.What I didn't realize is that all lookups have a
&Name
reference. We never have a case where we just have a&str
.That's why I'm removing the
Lookup
implementation because I prefer ifruff-python-ast
doesn't depend on salsa, even if optionally.Test Plan
cargo test