Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python 3.12 for fuzz-parser in CI #14159

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Use Python 3.12 for fuzz-parser in CI #14159

merged 2 commits into from
Nov 7, 2024

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Nov 7, 2024

Summary

Looks like merging #14156 broke CI on the main branch. I thought I was safe to enable automerge as I'd done extensive testing locally -- more fool me!

It looks like the problem is something to do with f-strings, so I'm guessing PEP-701 is to blame. Let's see if upgrading our Python versions in CI to 3.13 (which is what I used for local testing) fixes things.

@AlexWaygood AlexWaygood added the ci Related to internal CI tooling label Nov 7, 2024
@AlexWaygood AlexWaygood marked this pull request as ready for review November 7, 2024 15:26
@AlexWaygood
Copy link
Member Author

Python 3.13 breaks ruff-lsp. Let's try 3.12!

@AlexWaygood AlexWaygood changed the title Use Python 3.13 for fuzz-parser in CI Use Python 3.12 for fuzz-parser in CI Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@AlexWaygood AlexWaygood merged commit adc4216 into main Nov 7, 2024
20 checks passed
@AlexWaygood AlexWaygood deleted the alex/fix-ci branch November 7, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to internal CI tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants