Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pay_as_clear and pay_as_bid in edge cases #466

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maurerle
Copy link
Member

some bids did appear twice in the rejected bids
bids with an accepted_volume of 0 were still accepted in pay_as_bid

This does produce the expected results for all 4 possible clearing scenarios

Screenshots:

image

image

image

image

some bids did appear twice in the rejected bids
bids with an accepted_volume of 0 were still accepted in pay_as_bid
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.76%. Comparing base (6f628ab) to head (97c1171).

Files with missing lines Patch % Lines
assume/markets/clearing_algorithms/simple.py 85.71% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #466   +/-   ##
=======================================
  Coverage   76.75%   76.76%           
=======================================
  Files          50       50           
  Lines        6272     6278    +6     
=======================================
+ Hits         4814     4819    +5     
- Misses       1458     1459    +1     
Flag Coverage Δ
pytest 76.76% <85.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant